Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add reference to CI workflow to fix error #839

Merged
merged 1 commit into from Mar 25, 2024
Merged

fix: add reference to CI workflow to fix error #839

merged 1 commit into from Mar 25, 2024

Conversation

ghost
Copy link

@ghost ghost commented Feb 22, 2024

Description

I noticed one of the CI workflows incorrectly references machulav/ec2-github-runner. GitHub requires a reference to use an action, so I added the V2 tag, and this should fix CI failures.

Commit Message

type: commit message

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines
  • I have added version bump label on PR.

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@ghost ghost changed the title fix: fix reference to action in a CI workflow fix: add reference to CI workflow to fix error Feb 22, 2024
@DeepakBomjan DeepakBomjan merged commit 5bd6c10 into icon-project:main Mar 25, 2024
1 check passed
@ghost
Copy link
Author

ghost commented Mar 25, 2024

/run e2e

EDIT: workflow runs at least now

ibrizsabin added a commit that referenced this pull request May 15, 2024
* feat: add wasm client project

* fix: add wasm proto

* fix: import ics08wasm

* fix: import wasm-08

* fix: generalize context

* fix: build deps

* fix: fix deps issue

* fix: split query handler

* fix: wrap result in response

* feat: add verify header

* feat: add genesis export

* fix: impl client status

* fix: fix unit test

* fix: add debug logs

* fix: cleanup

* chore: pass build

* fix: proto changes

* fix: split traits

* chore: pass build

* fix: remove inner

* fix: query handler

* fix: add tests

* fix: add update test

* fix: downgrade

* fix: downgrade cosmwasm

* fix: update test utils

* fix: point to downgraded xcall

* fix: lower multi test

* fix: lock on 1.6

* fix: revert downgrade

* fix: try disable features

* fix: upgrade cw-storage-plus

* fix: lock to 1.4

* fix: move cw-multi test

* chore: pass build

* fix: fix branch

* fix: add height

* fix: cleanup

* chore: pass build

* fix: remove toolchain.toml

* fix: fix verify membership

* fix: ack hashing

* doc: add build note

* chore: pass build

* fix: do sha256

* fix: check misbehaviour

* chore: pass build

* fix:resolve comments

* chore: pass build

* fix: remove unnecessary hash

* chore: pass build

* fix: rename client id

* fix: Fix reverse sign on timestamp check for request timeout

* chore: update test coverage for ibc client (#846)

* chore: update test coverage for ics03-connection (#848)

* chore: update test coverage for ibc client

* chore: improve test coverage for ibc connection

* chore: add test coverage for cosmwasm ibc core (#850)

* docs: Add explanation on how a connection can be manually verified (#838)

doc: Add explanation on how a connection can be manually verified

* fix: add reference to CI workflow to fix error (#839)

Co-authored-by: ForwardSlashBack <ForwardSlashBack@users.noreply.github.com>

* chore: add unit test coverage for icon light client (#851)

* ci: add injectived, and neutornd binary (#858)

* ci: add injectived, and neutornd binary

* ci: update archwayd to v6.0.0

* ci: update archwayd to v6.0.0

* chore: add test coverage for xcall-ibc-connection (#853)

* fix: fix test

* fix: resolve test issues

* fix: cargo fmt

---------

Co-authored-by: AntonAndell <anton@andell.eu>
Co-authored-by: undefined <107839945+bishalbikram@users.noreply.github.com>
Co-authored-by: ForwardSlashBack <142098649+ForwardSlashBack@users.noreply.github.com>
Co-authored-by: ForwardSlashBack <ForwardSlashBack@users.noreply.github.com>
Co-authored-by: DeepakBomjan <44976635+DeepakBomjan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant