Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Apply code improvments suggested during audit #831

Merged
merged 1 commit into from
Mar 21, 2024
Merged

feat: Apply code improvments suggested during audit #831

merged 1 commit into from
Mar 21, 2024

Conversation

AntonAndell
Copy link
Collaborator

@AntonAndell AntonAndell commented Feb 12, 2024 •
edited
Loading

Description

Commit Message

type: commit message

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines
  • I have added version bump label on PR.

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@AntonAndell AntonAndell added the enhancement New feature or request label Feb 12, 2024
@ibrizsabin ibrizsabin merged commit ad5c712 into 810-verify-trust-level-to-be-larger-than-13-on-tendermint-client-creation Mar 21, 2024
13 of 14 checks passed
@ibrizsabin ibrizsabin deleted the 813-audit-code-improvements-suggestions branch March 21, 2024 06:03
ibrizsabin pushed a commit that referenced this pull request Apr 26, 2024
@AntonAndell
fix: Require tendermint clientstate trustlevel to be >= 1/3 (#828)
5fcf54c 
* feat: Add revision number to light client heights

Add revision number but for now do not add support for resseting chain height

* wip

* revert to using two clients

* feat: add IBC prefix for ics-08 clients and bugfixes

* fix: Require tendermint clientstate trustlevel to be >= 1/3

* feat: Apply code improvments suggested during audit (#831)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrizsabin ibrizsabin ibrizsabin approved these changes

@redlarva redlarva Awaiting requested review from redlarva

@nightowl121 nightowl121 Awaiting requested review from nightowl121

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AntonAndell @ibrizsabin