Skip to content

Commit

Permalink
Adding Canvas.user.loginId to the default list of custom variables
Browse files Browse the repository at this point in the history
While we only ever needed this for the VitalSource integration,
as a the field to fetch the user reference, it's less error prone
to always ask for it in every new install.
  • Loading branch information
marcospri committed Feb 21, 2025
1 parent 3739dbe commit b53b9a4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions lms/views/canvas/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
("custom_canvas_course_id", "$Canvas.course.id"),
("custom_canvas_api_domain", "$Canvas.api.domain"),
("custom_canvas_user_id", "$Canvas.user.id"),
("custom_canvas_user_login_id", "$Canvas.user.loginId"),
("custom_display_name", "$Person.name.display"),
("custom_context_id_history", "$Context.id.history"),
("custom_course_starts", "$Canvas.course.startAt"),
Expand Down
1 change: 1 addition & 0 deletions tests/unit/lms/views/canvas/config_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ def test_it(self, pyramid_request):
"custom_canvas_course_id": "$Canvas.course.id",
"custom_canvas_api_domain": "$Canvas.api.domain",
"custom_canvas_user_id": "$Canvas.user.id",
"custom_canvas_user_login_id": "$Canvas.user.loginId",
"custom_display_name": "$Person.name.display",
"custom_context_id_history": "$Context.id.history",
"custom_course_starts": "$Canvas.course.startAt",
Expand Down

0 comments on commit b53b9a4

Please sign in to comment.