Avoid eagerly doing unnecessary string formatting #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludfjig
changed the title
ludfjig
changed the title
ludfjig
force-pushed
the
lazy_eval_error
branch
2 times, most recently
from
41a3fb3 to
81288e9
Compare
simongdavies
previously approved these changes
Nov 20, 2024
Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
ludfjig
force-pushed
the
lazy_eval_error
branch
from
81288e9 to
7d5ba05
Compare
Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
ludfjig
force-pushed
the
lazy_eval_error
branch
from
7d5ba05 to
3d46c71
Compare
Merged
danbugs
approved these changes
Nov 21, 2024
dblnz
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from
.ok_orto.ok_or_elsedo only perform the string formatting in the failing case.Benchmarks show that time to create an uninitialized sandbox goes from 400µs to about 330µs (-17%) on my local machine
Also adds an
amdtag that was forgotten in PR #74