[dependencies] add Cargo.lock #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ran cargo +nightly udeps to find then remove unused dependencies Signed-off-by: danbugs <danilochiarlone@gmail.com>
…d Cargo.lock ran cargo update to update the Cargo.lock Signed-off-by: danbugs <danilochiarlone@gmail.com>
Signed-off-by: danbugs <danilochiarlone@gmail.com>
Signed-off-by: danbugs <danilochiarlone@gmail.com>
danbugs
force-pushed
the
danbugs/add-cargo-lock
branch
from
86a7cea to
a08a19c
Compare
simongdavies
approved these changes
Nov 18, 2024
auto-merge was automatically disabled
November 18, 2024 21:04
Base branch requires signed commits
simongdavies
pushed a commit
to simongdavies/hyperlight
that referenced
this pull request
Nov 18, 2024
* [dependencies] removed unused dependencies ran cargo +nightly udeps to find then remove unused dependencies Signed-off-by: danbugs <danilochiarlone@gmail.com> * [dependencies] removed Cargo.lock from .gitignore and included updated Cargo.lock ran cargo update to update the Cargo.lock Signed-off-by: danbugs <danilochiarlone@gmail.com> * [dependencies] bringing back uuid but as a dev-dependency Signed-off-by: danbugs <danilochiarlone@gmail.com> * [dependencies] re-adding rust-embed and sha256 as windows dependencies Signed-off-by: danbugs <danilochiarlone@gmail.com> --------- Signed-off-by: danbugs <danilochiarlone@gmail.com> Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before 2023, Cargo recommended developers to git ignore
Cargo.lockfiles for libraries. The official policy/recommendation for this has changed. I think we should be okay to includeCargo.lockas a way of tracking working combinations of dependencies. Plus, combining this w/ Dependabot, we should be constantly updating to the latest versions of crates regardless.closes #37