Fix otlp tracing #61
Merged
Fix otlp tracing #61
+129
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblnz
added
kind/bugfix
simongdavies
previously approved these changes
Nov 15, 2024
ludfjig
previously approved these changes
Nov 15, 2024
Signed-off-by: Doru Blânzeanu <dblnz@pm.me>
Signed-off-by: Doru Blânzeanu <dblnz@pm.me>
Signed-off-by: Doru Blânzeanu <dblnz@pm.me>
Signed-off-by: Doru Blânzeanu <dblnz@pm.me>
dblnz
force-pushed
the
fix-otlp-tracing
branch
from
3d6faa8 to
4c693ce
Compare
ludfjig
approved these changes
Nov 22, 2024
marosset
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the otlp_tracing example compile issues with latest opentelemetry crate.
It required a slightly different approach to set up the tracer. The examples from tracing-opentelemetry crate were useful.
One other side of the problem was that
jaegerdidn't receive the traces from the example anymore and it turns out it is because of the log filtering. So, using a differentRUST_LOGshould suffice.The new test added sets up a TcpListener that binds to the same address the tracer subscriber does so it is able to receive the traces so it can validate whether the example runs correctly