Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix README links #60

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Fix README links #60

merged 2 commits into from
Nov 18, 2024

Conversation

kk-src
Copy link
Contributor

@kk-src kk-src commented Nov 15, 2024

Fix the README links in "For developers" section to append .md file extension.
Fixes issue #59

@jprendes
Copy link
Contributor

jprendes commented Nov 15, 2024

Thanks @kk-src !
Would you mind signing off and signing (looks like it's already signed) your commit? Thanks!

@jprendes jprendes added the area/documentation Improvements or additions to documentation label Nov 15, 2024
@kk-src
Copy link
Contributor Author

kk-src commented Nov 15, 2024

Thanks @kk-src ! Would you mind signing off and signing (looks like it's already signed) your commit? Thanks!

Thank you @jprendes. Added the Signed-off-by to the commit message.

Copy link
Contributor

@jprendes jprendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Thanks @kk-src !

@ludfjig
Copy link
Contributor

ludfjig commented Nov 15, 2024

Looks like the commit is not signed @kk-src , maybe it got unsigned when you added the sign-off ?

@kk-src kk-src force-pushed the readme-fixes branch 2 times, most recently from 1b3dbce to 96b7f3e Compare November 18, 2024 06:26
Fix the README links in "For developers" section to append .md file extension(issue hyperlight-dev#59).

Signed-off-by: Krishnakumar R (KK) <65895020+kk-src@users.noreply.github.com>
@jprendes jprendes merged commit 558915f into hyperlight-dev:main Nov 18, 2024
8 checks passed
@jprendes
Copy link
Contributor

Thanks @kk-src !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants