Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fuzzing target to fuzz return type and parameters #301

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add fuzzing target to fuzz return type and parameters #301

wants to merge 1 commit into from

Conversation

ludfjig
Copy link
Contributor

@ludfjig ludfjig commented Feb 28, 2025 •
edited
Loading

  • Adds a new fuzzing target for fuzzing parameters to guest func
  • Renames existing fuzzing target, and switch to use Arbitrary to generate input.
  • Make fuzzing more efficient by re-using sandbox
  • Fixes our cron fuzz target which is supposed to fuzz for a long time every sunday, but was only fuzzing for 5 minutes
  • Moves fuzzing up to root directory

In order to merge this PR, we need to remove fuzz/fuzzing status check from branch protection, as this PR changes the name of that job to fuzz/fuzzing (guest_call) and fuzz/fuzzing (host_print)

@ludfjig ludfjig force-pushed the fuzz_parameters branch 2 times, most recently from b2d86f7 to 42f6f6c Compare February 28, 2025 18:49
@ludfjig ludfjig marked this pull request as ready for review February 28, 2025 19:19
dblnz
dblnz previously approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@dblnz dblnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Good work on improving the verifications we do on the changes.

@ludfjig ludfjig changed the title Change fuzzing target to fuzz return type and parameters Add fuzzing target to fuzz return type and parameters Mar 4, 2025
@ludfjig ludfjig force-pushed the fuzz_parameters branch 11 times, most recently from a698217 to e4443f9 Compare March 4, 2025 21:06
@ludfjig
Adds fuzzing target to fuzz the ParameterValue and ReturnType. Rename
2e2c893 
existing target to host_print. Move fuzz directory to root directory.

Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
@simongdavies
Copy link
Contributor

In order to merge this PR, we need to remove fuzz/fuzzing status check from branch protection, as this PR changes the name of that job to fuzz/fuzzing (guest_call) and fuzz/fuzzing (host_print)

I removed the fuzz check temporarily, once this merges let me know and I will add the 2 new ones

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simongdavies simongdavies simongdavies approved these changes

@dblnz dblnz dblnz left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
area/process kind/refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ludfjig @simongdavies @dblnz