Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dataexchange] Fixing Deadlock on Reconnect #1654

Merged

Conversation

onelapahead
Copy link
Contributor

Proposed changes

If you restart a DX FF is connected to, it will cause FF to initialize and reconnect to it.

But with the recent #1652, we want to check the node's identity status relative to the DX config, but we wrongfully checked if the DX plugin was initialized - causing a deadlock since during reconnect we are holding the lock that re-initializes the plugin 🔁 .

It's safe to check the node identity status when we are not initialized since it is the same thing as GetEndpointInfo with some extra work.

Types of changes

  • Bug fix
  • New feature added
  • Documentation Update

Please make sure to follow these points

  • I have read the contributing guidelines.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • My Pull Request title is in format < issue name > eg Added links in the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • My changes have sufficient code coverage (unit, integration, e2e tests).

Screenshots (If Applicable)


Other Information

See kaleido-io#125 for original downstream fix.

Signed-off-by: hfuss <hayden.fuss@kaleido.io>
@onelapahead onelapahead requested a review from a team as a code owner March 4, 2025 18:41
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (e486b2e) to head (5684ee4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1654      +/-   ##
==========================================
- Coverage   99.95%   99.95%   -0.01%     
==========================================
  Files         339      339              
  Lines       29782    29780       -2     
==========================================
- Hits        29770    29768       -2     
  Misses          8        8              
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterbroadhurst peterbroadhurst merged commit a96b39f into hyperledger:main Mar 4, 2025
19 checks passed
@onelapahead onelapahead deleted the dxstatuscheck-deadlock-fix2 branch March 4, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants