Skip to content

Commit

Permalink
Update npm version used by Node
Browse files Browse the repository at this point in the history
npm v9.3.1 that shipped with Node v18.14.0 broke linked dependencies. This is fixed in later npm v9.x releases. Update the npm version after Node install to pick up any npm fixes available as quickly as possible.

Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
  • Loading branch information
bestbeforetoday committed Feb 14, 2023
1 parent 0939eae commit dd6fff2
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 6 deletions.
8 changes: 8 additions & 0 deletions .github/workflows/push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ jobs:
with:
node-version: 18
registry-url: 'https://registry.npmjs.org'
- name: Update npm
run: |
npm update --global npm
npm --version
- uses: actions/checkout@v3
- run: npm install
- run: npm run compile
Expand All @@ -35,6 +39,10 @@ jobs:
- uses: actions/setup-node@v3
with:
node-version: 18
- name: Update npm
run: |
npm update --global npm
npm --version
- name: Checkout source
uses: actions/checkout@v3
with:
Expand Down
10 changes: 4 additions & 6 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,22 +34,20 @@ jobs:
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}

- name: Update npm
run: |
npm update --global npm
npm --version
- name: Install SoftHSM
run: |
sudo apt-get install softhsm2
softhsm2-util --init-token --slot 0 --label "ForFabric" --pin 98765432 --so-pin 1234
- run: npm install

- name: Generate credentials
run: npm run installAndGenerateCerts

- name: Pull Fabric images
run: npm run pullFabricImages

- run: npm test

- name: "Archive unit test debug log"
if: ${{ failure() }}
uses: actions/upload-artifact@v3
Expand Down

0 comments on commit dd6fff2

Please sign in to comment.