initial pass at adding riscv64 support in besu-native #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gary Schulte <garyschulte@gmail.com>
garyschulte
commented
Mar 4, 2025
| @@ -16,7 +16,6 @@ | |||
| rootProject.name='besu-native' | |||
| include 'arithmetic' | |||
| include 'blake2bf' | |||
| include 'bls12-381' | |||
There was a problem hiding this comment.
fixing this vestigial bit of matter-labs lib which was removed in #225
Signed-off-by: Gary Schulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
macfarla
approved these changes
Mar 4, 2025
| // Skip for riscv64 since we are not building constantine for riscv64 yet | ||
| enabled = false | ||
| } else { | ||
| // environment 'LD_LIBRARY_PATH', "${System.env.LD_LIBRARY_PATH}:build/resources/main/linux-gnu-x86_64" |
There was a problem hiding this comment.
ah, yeah. that is informational since it is an alternative way to find the built library in the path. I will remove it though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow besu-native to build on linux-gnu-riscv64 , ignore constantine and blake2.
This PR just adds the build targets, it does not add CI for riscv64. The resulting merge will not automatically create a riscv64 compatible besu-native release.
Tested on bpif3 with Armbian