Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to a version of rust-verkle which uses little endian #143

Merged
merged 10 commits into from
Jan 29, 2024

Conversation

kevaundray
Copy link
Contributor

This uses a version of rust-verkle which uses little-endian.

This is not a breaking change because we change the endianness in the jni library. We can make a separate PR to change besu-verkle and other components to use little endian. Doing it this way reduces the amount of moving parts to making this change.

Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
@kevaundray
Copy link
Contributor Author

This is based off #139 -- once that is merged the diff will be smaller

Signed-off-by: Karim Taam <karim.t2am@gmail.com>
Copy link
Contributor

@matkt matkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matkt matkt enabled auto-merge (squash) January 29, 2024 15:01
@matkt matkt merged commit 4f55a89 into hyperledger:main Jan 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants