Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation note #1485

Merged
merged 10 commits into from
Jan 31, 2024
Merged

Conversation

joaniekube
Copy link
Contributor

@joaniekube joaniekube commented Jan 29, 2024

Closes #1469

Add note that Forest pruning is deprecated to where applicable

Signed-off-by: Joan Edwards <joan.edwards@consensys.net>
@joaniekube joaniekube requested a review from a team as a code owner January 29, 2024 18:40
Copy link

vercel bot commented Jan 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
besu-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 8:11pm

Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
@joaniekube
Copy link
Contributor Author

Thank you @alexandratran committed changes

Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjust links as necessary for different file locations.

Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
@alexandratran
Copy link
Contributor

@joaniefromtheblock Can you re-check the links from your local editor/preview? I roughly estimated the links in my PR suggestions but the PR is yielding a build error for the links, so it will require testing and fixing them locally.

Signed-off-by: Joan Edwards <joan.edwards@consensys.net>
Signed-off-by: Joan Edwards <joan.edwards@consensys.net>
Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, otherwise LGTM.

Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
@alexandratran alexandratran merged commit dc52b87 into hyperledger:main Jan 31, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add deprecation warnings for Forest pruning
3 participants