Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix incorrect variable check for fallbackRoutingHook #611

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

barajeel
Copy link
Contributor

Description

Fixed an incorrect variable check in the script. Previously, the condition was checking merkle_tree_hook instead of fallback_routing_hook. Now, it correctly verifies fallbackRoutingHook before proceeding, ensuring the intended logic is applied.

Backward compatibility

No breaking changes. The fix only corrects the variable being checked, preserving existing behavior while ensuring proper validation.

Testing

Manually tested by running the script on various addresses.yaml files, confirming that fallbackRoutingHook is correctly validated and the script behaves as expected.

Copy link

changeset-bot bot commented Feb 21, 2025

⚠️ No Changeset found

Latest commit: 12fd38c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@paulbalaji paulbalaji merged commit 40da5cb into hyperlane-xyz:main Feb 21, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants