Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: notes on poll_frame return values #144

Merged
merged 2 commits into from
Jan 31, 2025
Merged

docs: notes on poll_frame return values #144

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0829679
docs: notes on poll_frame return values
cratelyn Jan 10, 2025
eeafd33
review: update stale "data buffer" terminology
cratelyn Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions http-body/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,21 @@ pub trait Body {

#[allow(clippy::type_complexity)]
/// Attempt to pull out the next data buffer of this stream.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this isn't part of the PR, but I just noticed this is old. I think this is when the functions were separate, poll_data and poll_trailers. It should mention just the "next frame" instead of data specifically.

If you want to fix it up :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes! i didn't want to change it unprompted, but i can do that.

eeafd33

///
/// # Return value
///
/// This function returns:
///
/// - [`Poll::Pending`] if the next frame is not ready yet.
/// - [`Poll::Ready(Some(Ok(frame)))`] when the next frame is available.
/// - [`Poll::Ready(Some(Err(error)))`] when an error has been reached.
/// - [`Poll::Ready(None)`] means that all of the frames in this stream have been returned, and
/// that the end of the stream has been reached.
///
/// If [`Poll::Ready(Some(Err(error)))`] is returned, this body should be discarded.
///
/// Once the end of the stream is reached, implementations should continue to return
/// [`Poll::Ready(None)`].
fn poll_frame(
self: Pin<&mut Self>,
cx: &mut Context<'_>,
Expand Down