Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Onnx Config for PoolFormer #19962

Closed
wants to merge 0 commits into from
Closed

Conversation

BakingBrains
Copy link
Contributor

What does this PR do?

Fixes # (#16308)

Add changes to make PoolFormer models available for Onnx conversion.

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@chainyo

@BakingBrains
Copy link
Contributor Author

I have ran
RUN_SLOW=1 pytest tests/onnx/test_onnx_v2.py -k "poolformer"

tt

@BakingBrains
Copy link
Contributor Author

Conversion output

tt2

@BakingBrains
Copy link
Contributor Author

@chainyo @lewtun Any suggestions here?

Thanks and Regards.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Copy link
Contributor

@chainyo chainyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

Don't forget to use $ make fixup command before pushing your work.

@BakingBrains
Copy link
Contributor Author

BakingBrains commented Nov 4, 2022

Any updates on this PR?

@BakingBrains
Copy link
Contributor Author

@chainyo Any updates here?

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@chainyo
Copy link
Contributor

chainyo commented Dec 20, 2022

Hey @lewtun and @michaelbenayoun, we should merge this before the Optimum change.

Could you help on this?

@michaelbenayoun
Copy link
Member

Hi @chainyo,
The change is already here, I think the PR can be merged once the conflicts are resolved.
Also @BakingBrains could you add it to Optimum as well? It should not require much effort. If not, I can make it myself.

Copy link
Member

@michaelbenayoun michaelbenayoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (after resolving conflicts)

@BakingBrains
Copy link
Contributor Author

@michaelbenayoun Sure, I will add it to Optimum.

Thank you

@BakingBrains
Copy link
Contributor Author

I tried to resolve the conflicts, but I think I messed up

@BakingBrains
Copy link
Contributor Author

BakingBrains commented Dec 22, 2022

I just reopened a new pull request for the same with resolved conflicts, can you please check @michaelbenayoun
#20868

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants