Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handle for empty fsdp_config[xla_fsdp_v2] #1706

Merged

Conversation

jingyanwangms
Copy link
Contributor

@jingyanwangms jingyanwangms commented Feb 20, 2024

What does this PR do?

Fixes # 1705

@jingyanwangms
Copy link
Contributor Author

@JingyaHuang can you please review it?

@IlyasMoutawwakil
Copy link
Member

LGTM

Copy link
Contributor

@JingyaHuang JingyaHuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@JingyaHuang JingyaHuang merged commit 990c203 into huggingface:main Feb 23, 2024
20 of 45 checks passed
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

young-developer pushed a commit to young-developer/optimum that referenced this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyError: 'xla_fsdp_v2' in self.is_fsdp_xla_v2_enabled = args.fsdp_config["xla_fsdp_v2"]
4 participants