move model for export preparation to be able reuse in other exporters

[eaidova]

What does this PR do?

This PR propose to move model preparation to export outside onnx exporter for ability reuse it in different exporters (e.g. openvino, neuron) that may have own export configs. Changes are backward compatible for onnx export, should not affect other components, but will help in reusage models preparation (partitioning, building export configs) in other optimum exporters

[echarlaix]

LGTM !

[fxmarty]

It looks OK to me, but keep in mind optimum main repo CI is only testing ONNX export.

[fxmarty]

Is this change related to the refactor?

[eaidova]

it is not related to refactoring, it fixes bug that prevent registering tasks with-past in this case (I found it testing on optimum-intel side for registering configs for openvino)

[fxmarty]

@eaidova Could you push an empty commit (or alternatively merge main), so that we run with #1707 & run the CI?

[eaidova]

@eaidova Could you push an empty commit (or alternatively merge main), so that we run with #1707 & run the CI?

@fxmarty done

[fxmarty]

@eaidova Thank you, can you install ruff==0.1.5 and run make style?

[eaidova]

@eaidova Thank you, can you install ruff==0.1.5 and run make style?

@fxmarty, check_code_quality reports issues in optimum/optimum/examples/onnxruntime/training/image-classification/run_image_classification.py that was not modified by me. Should I fix it?

[fxmarty]

yes please, sorry if it is unrelated

[fxmarty]

Can you fix

exporters/onnx/test_onnx_export.py:30: in <module>
    from optimum.exporters.onnx import (
E   ImportError: cannot import name 'get_decoder_models_for_export' from 'optimum.exporters.onnx' (/home/runner/work/optimum/optimum/optimum/exporters/onnx/__init__.py)

Maybe it's good to keep backward compatibility in exporters/onnx/utils.py (just importing from exporters/utils.py & redefining the functions), with warnings that the functions will be removed in a future version. Although not explicitly exposed, maybe some people use these utils.

[eaidova]

Can you fix

exporters/onnx/test_onnx_export.py:30: in <module>
    from optimum.exporters.onnx import (
E   ImportError: cannot import name 'get_decoder_models_for_export' from 'optimum.exporters.onnx' (/home/runner/work/optimum/optimum/optimum/exporters/onnx/__init__.py)

Maybe it's good to keep backward compatibility in exporters/onnx/utils.py (just importing from exporters/utils.py & redefining the functions), with warnings that the functions will be removed in a future version. Although not explicitly exposed, maybe some people use these utils.

@fxmarty added

[fxmarty]

Thank you LGTM, failing tests are unrelated!