Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ONNX export for owlv2 #1689

Merged
merged 4 commits into from
Feb 29, 2024
Merged

Add ONNX export for owlv2 #1689

merged 4 commits into from
Feb 29, 2024

Conversation

xenova
Copy link
Contributor

@xenova xenova commented Feb 9, 2024

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@xenova xenova marked this pull request as ready for review February 19, 2024 12:58
@xenova
Copy link
Contributor Author

xenova commented Feb 19, 2024

Working model: https://huggingface.co/Xenova/owlv2-base-patch16-ensemble (+ tested with transformers.js)

cc @fxmarty

Copy link
Contributor

@fxmarty fxmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fxmarty
Copy link
Contributor

fxmarty commented Feb 19, 2024

@xenova Can you also rebase/merge main?

@xenova
Copy link
Contributor Author

xenova commented Feb 19, 2024

Done! Turns out opset=14 isn't necessary 😇

@fxmarty
Copy link
Contributor

fxmarty commented Feb 26, 2024

@xenova Could you either push an empty commit or merge main (there was an issue with pytest that is now pinned)?

Can you also confirm that the exported model behaves as expected?

@fxmarty
Copy link
Contributor

fxmarty commented Feb 29, 2024

bump

@xenova
Copy link
Contributor Author

xenova commented Feb 29, 2024

Done! (sorry for the delay; missed previous notification)

@fxmarty fxmarty merged commit 8748081 into main Feb 29, 2024
50 of 63 checks passed
@fxmarty fxmarty deleted the add-owlv2 branch February 29, 2024 15:29
young-developer pushed a commit to young-developer/optimum that referenced this pull request May 10, 2024
* Add ONNX export for owlv2

* Remove opset=14 requirement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants