-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-enable decoder sequence classification #1679
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thank you for the fix!
Digging into some test failures Failing on main:
Failing on this branch:
but they pass locally for me. They appear to print out some warnings about tracing, wonder if my env is different than the CI env
Results of
|
Thank you @dwyatte, these failing tests are fine as unrelated, and fixed in #1683 & microsoft/onnxruntime#19421 |
7256b14
to
0add749
Compare
Great, just rebased so I think this should be ready to go now |
Thank you! |
* re-enable decoder sequence classification * update tests * revert to better pad token handling logic * minor updates * format
What does this PR do?
Re-enables sequence classification for decoder-based models. This requires a user to pass in
--pad_token_id
which required a change to the testsI also removed a default pad token override for GPT-2 which seemed like a bad idea (sets it to 0, which corresponds to
!
) -- let me know if this is problematicThis passes a fair number of tests in
tests/exporters/onnx/
for me, but I deselected some so we may need to iterate hereFixes #1527
Before submitting