Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make unet and vae number of channels static #692

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

eaidova
Copy link
Collaborator

@eaidova eaidova commented Apr 29, 2024

What does this PR do?

uses static number of channels for unet and vae as this value is important for model architecture (number of channels for convolutions) and can not be changed in runtime and always expected to be the same like provided in config

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@eaidova eaidova force-pushed the ea/sd_static_channles branch 2 times, most recently from af0fafb to f18d43d Compare April 29, 2024 06:36
@eaidova eaidova force-pushed the ea/sd_static_channles branch from f18d43d to 482197a Compare April 29, 2024 06:41
Copy link
Contributor

@slyalin slyalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the description, it will simplify application code when exported OV model is being deployed without the need to hardcode internal parameters in the application or reading them from config files.

Copy link
Collaborator

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, why not adding it to optimum instead ?

@eaidova
Copy link
Collaborator Author

eaidova commented Apr 29, 2024

LGTM, why not adding it to optimum instead ?

@echarlaix, I'll open the same PR to optimum too if you agree, I just want unblock some work on openvino side where these changes can simplify demo workflow as soon as possible

@echarlaix
Copy link
Collaborator

LGTM, why not adding it to optimum instead ?

@echarlaix, I'll open the same PR to optimum too if you agree, I just want unblock some work on openvino side where these changes can simplify demo workflow as soon as possible

works for me thanks @eaidova

@echarlaix echarlaix merged commit 805335c into huggingface:main Apr 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants