make unet and vae number of channels static #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
eaidova
force-pushed
the
ea/sd_static_channles
branch
2 times, most recently
from
af0fafb to
f18d43d
Compare
eaidova
force-pushed
the
ea/sd_static_channles
branch
from
f18d43d to
482197a
Compare
slyalin
approved these changes
Apr 29, 2024
echarlaix
approved these changes
Apr 29, 2024
@echarlaix, I'll open the same PR to optimum too if you agree, I just want unblock some work on openvino side where these changes can simplify demo workflow as soon as possible |
works for me thanks @eaidova |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
uses static number of channels for unet and vae as this value is important for model architecture (number of channels for convolutions) and can not be changed in runtime and always expected to be the same like provided in config