Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small OpenVINO UX improvements #629

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

helena-intel
Copy link
Collaborator

  • Set PERFORMANCE_HINT to LATENCY if not specified in ov_config.

Also added an ov_config parameter to OVModelForSeq2SeqLM which did not exist yet. Setting an explicit ov_config worked, but the default ov_config with LATENCY hint was not provided.
LATENCY is the default at the moment for both GPU and CPU so we could remove this entirely, but defaults can change, I think it's fine to keep it explicit.

  • Replace warning log in .to() about devices with debug log

My goal for removing the warning is to prevent confusing users who create a pipeline(), which always shows this warning. Making this .debug() instead of .warning() doesn't show it by default, but developers could enable it. Also happy to remove it altogether.
image

- set PERFORMANCE_HINT to LATENCY if not specified in ov_config
- replace warning log in .to() about devices with debug log (to prevent
  confusing users who create a pipeline(), which always shows this warning)
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Comment on lines 267 to 270
self.ov_config = ov_config if ov_config is not None else {}

if self.ov_config.get("PERFORMANCE_HINT") is None:
self.ov_config["PERFORMANCE_HINT"] = "LATENCY"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be included to OVBaseModelForSeq2SeqLM instead ?

self.ov_config = ov_config if ov_config is not None else {}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thank you! I changed it.

@echarlaix echarlaix merged commit 77503fc into main Mar 22, 2024
12 checks passed
@echarlaix echarlaix deleted the helena/ov-config-hint-pipeline-warnings branch March 22, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants