Small OpenVINO UX improvements #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- set PERFORMANCE_HINT to LATENCY if not specified in ov_config - replace warning log in .to() about devices with debug log (to prevent confusing users who create a pipeline(), which always shows this warning)
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
echarlaix
approved these changes
Mar 22, 2024
Comment on lines
267
to
270
| self.ov_config = ov_config if ov_config is not None else {} | ||
|
|
||
| if self.ov_config.get("PERFORMANCE_HINT") is None: | ||
| self.ov_config["PERFORMANCE_HINT"] = "LATENCY" |
There was a problem hiding this comment.
shouldn't this be included to OVBaseModelForSeq2SeqLM instead ?
There was a problem hiding this comment.
Yes, thank you! I changed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added an ov_config parameter to OVModelForSeq2SeqLM which did not exist yet. Setting an explicit ov_config worked, but the default ov_config with LATENCY hint was not provided.
LATENCY is the default at the moment for both GPU and CPU so we could remove this entirely, but defaults can change, I think it's fine to keep it explicit.
My goal for removing the warning is to prevent confusing users who create a pipeline(), which always shows this warning. Making this .debug() instead of .warning() doesn't show it by default, but developers could enable it. Also happy to remove it altogether.
