Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tests running with nightly #1205

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

eaidova
Copy link
Collaborator

@eaidova eaidova commented Mar 18, 2025

What does this PR do?

  • for tokenizers failed bugs, it is expected and it failed due to new feature support, updated condition for expected number of toeknizers
  • for loading sd model from hub, some additional investigation from openvino side needed (I crated internal issue). Seems that model is too old and has some incompatible with new ov expected by cpu plugin values (I was not able to find info how it was created unfortunately, but it was uploaded more that 2 years ago...), as workaround suggest to update model

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@eaidova eaidova added the openvino-test Trigger OpenVINO slow tests label Mar 18, 2025
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@nikita-savelyevv nikita-savelyevv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that model is too old and has some incompatible with new ov expected by cpu plugin values.

Is it possible that some old but still popular models are affected too?

@eaidova
Copy link
Collaborator Author

eaidova commented Mar 18, 2025

Seems that model is too old and has some incompatible with new ov expected by cpu plugin values.

Is it possible that some old but still popular models are affected too?

it affects only very old IRs stored on hub (~2023-2022 year), original models are not affected.
I do not think that there are some popular among them

Copy link
Member

@IlyasMoutawwakil IlyasMoutawwakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, okay with updating the tiny diffusion model.

@IlyasMoutawwakil IlyasMoutawwakil merged commit 626006c into huggingface:main Mar 19, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
openvino-test Trigger OpenVINO slow tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants