upgrade transformers to 4.49 for patching models #1196
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
|
Hi @echarlaix @IlyasMoutawwakil . Please review this PR, thanks! |
| **kwargs, | ||
| ) -> None: | ||
| super().__init__() | ||
| self.max_batch_size = max_batch_size | ||
| default_device = torch.device("xpu") if ipex._C._has_xpu() else torch.device("cpu") |
There was a problem hiding this comment.
this seems more like a global variable, also if I understand correctly, if xpu device is available and ipex has xpu, it's okay, but what if xpu device is available and current ipex doesn't have xpu support, maybe warning the user and then proceding with cpu device makes sense.
setup.py
Outdated
| @@ -67,7 +67,7 @@ | |||
| "nncf": ["nncf>=2.14.0"], | |||
| "openvino": ["nncf>=2.14.0", "openvino>=2024.5.0", "openvino-tokenizers>=2024.5.0"], | |||
| "neural-compressor": ["neural-compressor[pt]>3.0", "accelerate", "transformers<4.46"], | |||
| "ipex": ["intel-extension-for-pytorch>=2.4", "transformers>4.46,<4.48", "accelerate"], | |||
| "ipex": ["intel-extension-for-pytorch>=2.4", "transformers>4.48,<4.50", "accelerate"], | |||
There was a problem hiding this comment.
we are only testing ipex 2.6.0, shouldn't we test the minimum version as well ? if it still works ofc, otherwise we should update the minimum version.
|
Hi @IlyasMoutawwakil . I have fixed your comments! |
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
Hi @echarlaix @IlyasMoutawwakil . I updated the transformers version to 4.49.0 in ipex backend. Please review it, thanks!