Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid extra reshaping to max_model_lenght for unet #1164

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

eaidova
Copy link
Collaborator

@eaidova eaidova commented Feb 17, 2025

What does this PR do?

unet in stable diffusion pipelines always is saved with dynamic shapes during export and uses reshape to set max_model_lenght from tokenizer before starting inference. Suggestion is remove reshape every model loading and set max_model_len as default value for encoder_hidden_state during export if it is known

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@eaidova eaidova requested a review from AlexKoff88 February 17, 2025 18:23
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@echarlaix echarlaix merged commit 8361e45 into huggingface:main Feb 18, 2025
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants