-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix misplaced configs saving #1159
Conversation
@l-bat could you please review |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
It looks like that the logic in the tests should be changed as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
4a94677
to
b78881a
Compare
@echarlaix @IlyasMoutawwakil could you please take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @eaidova
What does this PR do?
during diffusion pipeline loading,
_name_or_path
field overridden only for main pipeline config, while its components still contains paths for original pipeline. As te result, ioriginal config loaded using diffusers pytorch pipeline and saved on disk for ov diffusers pipeline are different (e.g. for too old models where config does not contains some important fields) it may lead to incorrect loading.Before submitting