Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix misplaced configs saving #1159

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Conversation

eaidova
Copy link
Collaborator

@eaidova eaidova commented Feb 12, 2025

What does this PR do?

during diffusion pipeline loading, _name_or_path field overridden only for main pipeline config, while its components still contains paths for original pipeline. As te result, ioriginal config loaded using diffusers pytorch pipeline and saved on disk for ov diffusers pipeline are different (e.g. for too old models where config does not contains some important fields) it may lead to incorrect loading.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@eaidova eaidova requested a review from AlexKoff88 February 12, 2025 19:29
@eaidova
Copy link
Collaborator Author

eaidova commented Feb 12, 2025

@l-bat could you please review

@eaidova eaidova changed the title fix misplaced configs loading fix misplaced configs saving Feb 12, 2025
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@AlexKoff88
Copy link
Collaborator

It looks like that the logic in the tests should be changed as well

Copy link
Contributor

@l-bat l-bat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eaidova eaidova force-pushed the ea/remove_config_copy branch from 4a94677 to b78881a Compare February 13, 2025 09:20
@eaidova
Copy link
Collaborator Author

eaidova commented Feb 13, 2025

@echarlaix @IlyasMoutawwakil could you please take a look?

Copy link
Collaborator

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eaidova

@echarlaix echarlaix merged commit 4e005c0 into huggingface:main Feb 13, 2025
15 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants