resolve complicated chat templates during tokenizer saving #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eaidova
commented
Feb 7, 2025
eaidova
commented
Feb 7, 2025
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
eaidova
force-pushed
the
ea/chat_template_simplification
branch
from
d4ba3f2 to
ccf3287
Compare
eaidova
force-pushed
the
ea/chat_template_simplification
branch
from
ccf3287 to
7cd9492
Compare
eaidova
commented
Feb 10, 2025
AlexKoff88
approved these changes
Feb 10, 2025
|
I am fine with the changes. @eaidova, can you please describe the idea briefly for the rest of the reviewers? |
Wovchena
added a commit
to Wovchena/openvino.genai-public
that referenced
this pull request
Feb 11, 2025
Depends on huggingface/optimum-intel#1151 Close openvinotoolkit#1663 Ticket 161313
Wovchena
added a commit
to Wovchena/openvino.genai-public
that referenced
this pull request
Feb 11, 2025
Depends on huggingface/optimum-intel#1151 Close openvinotoolkit#1663 Ticket 161313
github-merge-queue bot
pushed a commit
to openvinotoolkit/openvino.genai
that referenced
this pull request
Feb 12, 2025
Depends on huggingface/optimum-intel#1151 Close #1663 Ticket 161313
github-merge-queue bot
pushed a commit
to openvinotoolkit/openvino.genai
that referenced
this pull request
Feb 12, 2025
Depends on huggingface/optimum-intel#1151 Close #1663 Ticket 161313
github-merge-queue bot
pushed a commit
to openvinotoolkit/openvino.genai
that referenced
this pull request
Feb 12, 2025
Depends on huggingface/optimum-intel#1151 Close #1663 Ticket 161313
github-merge-queue bot
pushed a commit
to openvinotoolkit/openvino.genai
that referenced
this pull request
Feb 13, 2025
Depends on huggingface/optimum-intel#1151 Close #1663 Ticket 161313
ilya-lavrenov
pushed a commit
to openvinotoolkit/openvino.genai
that referenced
this pull request
Feb 13, 2025
Depends on huggingface/optimum-intel#1151 Close #1663 Ticket 161313
eaidova
force-pushed
the
ea/chat_template_simplification
branch
from
56823cd to
df7e385
Compare
eaidova
force-pushed
the
ea/chat_template_simplification
branch
from
df7e385 to
bbc48e4
Compare
echarlaix
approved these changes
Feb 13, 2025
Co-authored-by: Ella Charlaix <80481427+echarlaix@users.noreply.github.com>
@echarlaix, thanks for review. I applied your comment. Could this PR be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently we have some issues with running some models with chat templates using C++ openvino API due to its chat template complexity parcing using C++. For smooth experience, we allow redefine them by own. To simplify such models usage, we want to provide C++ compatible simplified chat templates during tokenizer conversion (no impact on inference model with original python tokenizer) for several known and popular cases.
Additionally, it was found that sometimes running multimodal models (VLM), main chat template provided in processor instead of tokenizer as the result, our tokenizer conversion API ignore it. This PR fixes issue for such models.
Before submitting