Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix export phi3 with --trust-remote-code #1147

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

eaidova
Copy link
Collaborator

@eaidova eaidova commented Feb 6, 2025

What does this PR do?

phi3 exported incorrectly without patching if trust_remote_code=True and transformers>=4.48 (due to disabling patching)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@eaidova eaidova force-pushed the ea/fix_phi3_remote branch from 65f52a7 to a11acd8 Compare February 6, 2025 11:53
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@echarlaix echarlaix merged commit 4806df2 into huggingface:main Feb 6, 2025
16 of 22 checks passed
@eaidova eaidova deleted the ea/fix_phi3_remote branch February 11, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants