-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maira2 support #1145
maira2 support #1145
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @eaidova! Could you add a test before we can merge ?
@echarlaix I met some issues related to model configuration and compatibility with new transformers. Let me resolve it (at least for small testing model and I hope I'll add tests and docs) |
@echarlaix I added test and model into supported list. Could you please one more time? |
@echarlaix could you please help to rerun precommit. I updated model remote code for compatibility with python3.9 |
Done, looks like one last thing needs to be updated https://huggingface.co/katuni4ka/tiny-random-maira2/blob/main/processing_maira2.py#L347 to fix :
|
fixed |
What does this PR do?
Before submitting