Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relax requirement for patch size and config for llava preprocessor #1142

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

eaidova
Copy link
Collaborator

@eaidova eaidova commented Feb 5, 2025

What does this PR do?

  • add processor configuration parameters on export stage if missed
  • check and require config only for transformers>=4.48 (previous versions supports image preprocessing without patch_size)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@AlexKoff88
Copy link
Collaborator

@echarlaix, @IlyasMoutawwakil, please prioritize a review for this hot fix, thankt

@eaidova
Copy link
Collaborator Author

eaidova commented Feb 5, 2025

failed tests are not related to these changes (connection to hf hub issues, python3.9 streamer import issue with transformers 4.48 on langchain side), image downloading corruption

@echarlaix echarlaix merged commit 61a74cd into huggingface:main Feb 5, 2025
14 of 22 checks passed
github-merge-queue bot pushed a commit to openvinotoolkit/openvino.genai that referenced this pull request Feb 7, 2025
github-merge-queue bot pushed a commit to openvinotoolkit/openvino.genai that referenced this pull request Feb 7, 2025
github-merge-queue bot pushed a commit to openvinotoolkit/openvino.genai that referenced this pull request Feb 7, 2025
github-merge-queue bot pushed a commit to openvinotoolkit/openvino.genai that referenced this pull request Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants