Remove KV-cache compression disabling flag for compressed models #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
AlexKoff88
reviewed
Feb 5, 2025
AlexKoff88
approved these changes
Feb 5, 2025
eaidova
approved these changes
Feb 5, 2025
Co-authored-by: Alexander Kozlov <alexander.kozlov@intel.com>
nikita-savelyevv
commented
Feb 5, 2025
| [{"int8": 14, "int4": 16}, {"int8": 9}, {"int8": 1}], | ||
| [{"int8": 14, "int4": 16}, {"int8": 1}, {"int8": 9}], |
There was a problem hiding this comment.
Order of some reference values is changed because of the addition of this line: submodels = list(model.submodels.values()). This alters the order of submodels compared to before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
"KV_CACHE_PRECISION": "f16"rt info flag for all weight-compressed models. This way applying weight compression also enables KV cache compression.OVDynamicQuantizationConfig.Tests:
KV_CACHE_PRECISIONrt info flag is not present for compressed models.image-text-to-textmodels aslist(model.submodels.values()), this is more convenient.Before submitting