Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tests for compatibility with ov 2025.0 #1133

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

eaidova
Copy link
Collaborator

@eaidova eaidova commented Jan 29, 2025

What does this PR do?

  • openvino tokenizers in 2025.0 supports export detokenizer for bert and distilbert tokenizers
  • mt5 slightly dropped in accuracy due to internal sdpa fusion (in encoder part)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@eaidova eaidova added the openvino-test Trigger OpenVINO slow tests label Jan 29, 2025
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@eaidova eaidova force-pushed the ea/fix_tests_for_20250 branch from 81f25e2 to cbaee6b Compare January 29, 2025 14:29
@@ -1085,7 +1085,7 @@ def preprocess_function(examples, tokenizer):


class OVTrainerTest(unittest.TestCase):
SUPPORTED_ARCHITECTURES_WITH_EXPECTED_QUANTIZED_MATMULS = (("albert", 63, 39),)
Copy link
Collaborator

@nikita-savelyevv nikita-savelyevv Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is due to the fact that this test is somewhat non-deterministic (ticket 142945)

Copy link
Collaborator

@nikita-savelyevv nikita-savelyevv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@IlyasMoutawwakil IlyasMoutawwakil merged commit 214614c into huggingface:main Jan 30, 2025
28 checks passed
@eaidova eaidova deleted the ea/fix_tests_for_20250 branch January 30, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
openvino-test Trigger OpenVINO slow tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants