[OV]: Removed checks for transformers==4.36 #1063
Conversation
AlexKoff88
requested review from
IlyasMoutawwakil,
helena-intel and
echarlaix
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
@IlyasMoutawwakil, @echarlaix, please take a look and merge if you are ok with this. |
| @@ -26,7 +26,7 @@ jobs: | |||
| "*training*", | |||
| "*export*", | |||
| ] | |||
| transformers-version: ["4.36.0", "latest"] | |||
There was a problem hiding this comment.
I'm not at all against dropping v4.36 support, but would keep tests for the lowest "official" transformers version supported (we can an additional check for this), would that work ?
There was a problem hiding this comment.
Thanks Ella! Agreed, we should definitely keep testing the lowest supported version. I hope 4.37 works.
There was a problem hiding this comment.
@helena, appreciate if you could help to identify such a version?
There was a problem hiding this comment.
@AlexKoff88 Yes, testing now, I will create a new PR when everything works (because some minor changes are needed). Looks like 4.37 will work.
Agreed with @helena-intel to remove validation for transformers==4.36.