Add ability to enable/disable xet storage on a repo #2893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Wauplin
reviewed
Feb 28, 2025
| if gated is None and private is None: | ||
| raise ValueError("At least one of 'gated' or 'private' must be provided.") | ||
| # Check if gated, private, and xet_enabled are None | ||
| if gated is None and private is None and xet_enabled is None: |
There was a problem hiding this comment.
if condition gets bigger we could move this check below and do a
if len(payload) == 0:
raise ValueError("At least one setting must be updated.")=> after that, no need to update it if we add more settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
update_repo_settingsto add the ability to enable or disable xet storage.Note: No test has been added for now as xet storage is not properly integrated into the staging environment (https://hub-ci.huggingface.co/) and we cannot test in production for an obvious reason: the CI would need to be the owner of the repo to be able to update this setting.
A proper test will be added once the staging environment supports xet storage.
cc @bpronan