Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't Update Status or Notify for Cancelled Events #31

Closed
wants to merge 2 commits into from

Conversation

ashlyn
Copy link
Contributor

@ashlyn ashlyn commented Jun 15, 2020

I was recently sent a link to a cancelled meeting in Slack that I had not yet removed from my Outlook calendar, which seemed superfluous. The Microsoft Graph API exposes a flag indicating that the event has been cancelled and a filter function that can be used to filter out cancelled events from the query results.

This PR hasn't really been tested, other than testing the compiled API query string in the Microsoft Graph Explorer. Since it is changing the query, it should probably be tested independently before deploying.

@ashlyn ashlyn force-pushed the DontNotifyOnCancelledEvents branch from 6042f87 to a12dcef Compare June 15, 2020 15:07
@JDegner0129
Copy link
Member

@ashlyn nice, this would be a good thing to get pulled in. The branch conflicts actually aren't too bad; I just renamed a file. Want to resolve conflicts and we can get this merged?

@ashlyn
Copy link
Contributor Author

ashlyn commented Jul 17, 2020

I'll take a look at the merge conflicts this morning.

@vstehlik
Copy link
Contributor

This change was made in #102

@vstehlik vstehlik closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants