Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ELB): add params to lb listener resource #6571

Merged

Conversation

houpeng80
Copy link
Collaborator

What this PR does / why we need it:
add params to lb listener resource
Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

  add params to lb listener resource

PR Checklist

  • Tests added/passed.
make testacc TEST=./huaweicloud/services/acceptance/lb TESTARGS='-run TestAccLBV2Listener_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/lb -v -run TestAccLBV2Listener_ -timeout 360m -parallel 4
=== RUN   TestAccLBV2Listener_basic
=== PAUSE TestAccLBV2Listener_basic
=== RUN   TestAccLBV2Listener_https
=== PAUSE TestAccLBV2Listener_https
=== CONT  TestAccLBV2Listener_basic
=== CONT  TestAccLBV2Listener_https
--- PASS: TestAccLBV2Listener_basic (128.86s)
--- PASS: TestAccLBV2Listener_https (156.38s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/lb        156.427s
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2025
@github-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This PR has been approved by: @houpeng80

@houpeng80 houpeng80 force-pushed the lb_listener_add_params branch from 8f949ac to 1c2dade Compare March 27, 2025 02:00
@Jason-Zhang9309
Copy link
Collaborator

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Mar 29, 2025
@github-ci-robot github-ci-robot merged commit ab6e27c into huaweicloud:master Mar 29, 2025
13 checks passed
@houpeng80 houpeng80 deleted the lb_listener_add_params branch March 29, 2025 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants