-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor sidebar renders into methods (prep for mwc-list conversion) #7453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39520ff
to
8e141fe
Compare
bramkragten
reviewed
Oct 23, 2020
bramkragten
reviewed
Oct 23, 2020
You didn't change any actual logic here right? |
95% true. I arguably "changed the logic" with how items in edit mode are rendered. That is, I converted this flattened, in-line pattern:
And refactored into self-contained / parallel renderer structures:
In other words, you should be able to ignore everything except |
9eb5235
to
899d1ca
Compare
899d1ca
to
61da2a6
Compare
bramkragten
approved these changes
Oct 27, 2020
9 tasks
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
The sidebar render code is large and can be a bit difficult to reason about. This PR extracts the various "sections" of sidebar into their own render methods for better readability.
This is the first step toward converting sidebar to using mwc-list instead of paper-listbox. Related PR: #7326
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: