Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After navigating to another dashboard or switching browser tabs Quick Bar shortcut doesn't work until page clicked #7442

Closed
3 tasks done
gadgetchnnel opened this issue Oct 22, 2020 · 4 comments
Labels
Bug Current Bug in UI - Extra Attention stale

Comments

@gadgetchnnel
Copy link

gadgetchnnel commented Oct 22, 2020

Checklist

  • I have updated to the latest available Home Assistant version.
  • I have cleared the cache of my browser.
  • I have tried a different browser to see if it is related to my browser.

The problem

When navigating to another Lovelace dashboard or switching tabs in the browser, the keyboard shortcut for the Quick Bar doesn't work (brings up the standard print dialogue box instead) until the page is clicked.

Expected behavior

Quick Bar keyboard shortcut works immediately after navigating to another dashboard or switching tabs.

Steps to reproduce

Method 1

  1. Navigate to another Lovelace dashboard (or to another panel, such as Map and back to the same dashboard)
  2. Press Cmd+P in macOS or Ctrl+P in Windows

Method 2

  1. Switch to a different tab in the browser
  2. Switch back to the tab with Home Assistant
  3. Press Cmd+P in macOS or Ctrl+P in Windows

After doing either of these the print dialogue box will be displayed instead of the Quick Bar.
After clicking on the page the keyboard shortcut will display the Quick Bar as expected.

Environment

  • Home Assistant release with the issue: 0.117.0b1
  • Last working Home Assistant release (if known):
  • Browser and browser version: Chrome 86.0.4240.80
  • Operating system: macOS Catalina 10.15.7

State of relevant entities

Problem-relevant configuration

Javascript errors shown in your browser console/inspector

Additional information

@gadgetchnnel gadgetchnnel added the Bug Current Bug in UI - Extra Attention label Oct 22, 2020
@spacegaier
Copy link
Member

spacegaier commented Oct 22, 2020

The problem with method 1 is known (and I think covered in the documentation): The main content area of the page needs to have the focus currently. For it to work in the sidebar, some underlying things have to be changed in the frontend first, which are already being worked on.

Reg. method 2: Simply switching a tab in the browser does not impact the focus for me, so if the HA tab did have the proper focus before switching tabs, it still does once I come back to it and so the quick bar works for me (tested in Firefox 82)

@gadgetchnnel
Copy link
Author

I also haven't been able to reproduce the issue switching tabs again either, so the page probably didn't have focus before I switched tabs like you said.

@donkawechico
Copy link
Contributor

This is a known issue. The fix is to refactor the left nav to use <mwc-list> instead of <paper-listbox> (paper-listbox has a known bug with event propagation that will never be fixed).

This is non-trivial, but we already have a PR being worked on: #7326

@github-actions
Copy link

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.
Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 20, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Current Bug in UI - Extra Attention stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants