Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement user installations #2177

Merged
merged 27 commits into from
Mar 5, 2025
Merged

Implement user installations #2177

merged 27 commits into from
Mar 5, 2025

Conversation

mplatypus
Copy link
Contributor

@mplatypus mplatypus commented Mar 3, 2025 •
edited by davfsa
Loading

Summary

Add User install support!

This PR allows for commands to be added to user installed applications.

Checklist

  • I have run nox and all the pipelines have passed.
  • I have made unittests according to the code I have added/modified/deleted.

Related issues

Closes #1952
Closes #2192

mplatypus and others added 14 commits January 30, 2025 16:51
@mplatypus
Initial Commit
74bbc72
@mplatypus
Added Tests
13f3295
@mplatypus
Remove duplicate FIXME messages
afa1144
@mplatypus
Merge branch 'master' into feature/user-installs
b6dea2b
@mplatypus
Update decoding of application integration types.
98b4a3c
@mplatypus
Update handling of integration types, with a new constructor Applicat…
3ca952c 
…ionIntegrationConfiguration
@mplatypus
Remove FIXME stuff.
69b3053
@mplatypus
Update naming of variables.
975a3e1
@mplatypus
Add missing documentation.
d98a137
@mplatypus
Add authorizing integration owners and context to commands.
188ab1e
@mplatypus
Update entity factory test.
7cd159d
@mplatypus
Merge branch 'hikari-py:master' into feature/user-installs
dee42b6
@mplatypus
Merge branch 'feature/user-installs' of https://github.com/mplatypus/…
85acbcb 
…hikari into feature/user-installs
@mplatypus
Fix missing arguements for PartialInteraction objects in interaction …
1013380 
…server tests.
davfsa
davfsa requested changes Mar 3, 2025
View reviewed changes
Copy link
Member

@davfsa davfsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nitpicks, otherwise it looks really good!

@davfsa davfsa added the enhancement New feature or request label Mar 3, 2025
@davfsa
Copy link
Member

davfsa commented Mar 3, 2025 •
edited
Loading

Two more things:

  • app_permissions is no longer optional. The typehint should be updated to reflect this, as well as the deserialization
  • Messages will now contain interaction_metadata if they were created by an interaction followup. Its fields can be found here
  • Remove Commands.dm_permissions and Messages.interaction. Next release will be 2.2.0, which allows slightly breaking behaviour

@davfsa davfsa changed the title Feature/user installs Implement user installations Mar 3, 2025
davfsa
davfsa requested changes Mar 3, 2025
View reviewed changes
@davfsa davfsa self-requested a review March 5, 2025 00:48
davfsa
davfsa requested changes Mar 5, 2025
View reviewed changes
@davfsa davfsa mentioned this pull request Mar 5, 2025
Closed
davfsa
davfsa previously approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@davfsa davfsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your amazing work on this!

@davfsa davfsa merged commit 1306a12 into hikari-py:master Mar 5, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davfsa davfsa davfsa left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Commands.dm_permissions and Messages.interaction
2 participants
@mplatypus @davfsa