Skip to content

Commit

Permalink
[MSV] fix
Browse files Browse the repository at this point in the history
  • Loading branch information
hexdae committed Apr 4, 2024
1 parent 8a2ea25 commit 6f69341
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions extensions.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,13 @@ def _compare_versions(left, right):

def _minimal_supported_version(versions):
"""Obtains the minimum version from the list of version strings."""
minimum = versions.pop(0)
for version in versions:
if _compare_versions(minimum, version) > 0:
minimum = version
return minimum
if versions:
minimum = versions.pop(0)
for version in versions:
if _compare_versions(minimum, version) > 0:
minimum = version
return minimum
return None

def _arm_toolchain_impl(ctx):
"""Implement the module extension."""
Expand Down

0 comments on commit 6f69341

Please sign in to comment.