Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set an explicit PR reviewer for CNB builder release PRs #401

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

edmorley
Copy link
Member

Currently for CNB releases, the PR opened against cnb-builder-images doesn't have an explicit reviewer set by the automation, which means it uses that repo's CODEOWNERS default of requesting review from the whole Languages team.

As of heroku/languages-github-actions#289, the automation now supports passing a list of reviewers, which we can set for CNBs owned by a specific language owner.

This will help reduce review-request-spam to other team members.

Plus corrects the workflow names given this repo contains only a single CNB.

GUS-W-18011095.

Currently for CNB releases, the PR opened against `cnb-builder-images`
doesn't have an explicit reviewer set by the automation, which means it
uses that repo's `CODEOWNERS` default of requesting review from the
whole Languages team.

As of heroku/languages-github-actions#289, the
automation now supports passing a list of reviewers, which we can set
for CNBs owned by a specific language owner.

This will help reduce review-request-spam to other team members.

Plus corrects the workflow names given this repo contains only
a single CNB.

GUS-W-18011095.
@edmorley edmorley self-assigned this Mar 11, 2025
@edmorley edmorley requested a review from a team as a code owner March 11, 2025 12:56
@edmorley edmorley enabled auto-merge (squash) March 11, 2025 13:01
@edmorley edmorley merged commit b5fd48a into main Mar 11, 2025
7 checks passed
@edmorley edmorley deleted the edmorley/release-builder-pr-reviewer branch March 11, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants