Refactor test launch process definition #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmorley
approved these changes
Mar 19, 2025
edmorley
reviewed
Mar 19, 2025
Since the path is now passed as a quoted argument, including single quotes is interpreted as a literal part of the command name
runesoerensen
changed the title
heroku-linguist bot
added a commit
that referenced
this pull request
Mar 20, 2025
## heroku/dotnet ### Changed - The buildpack now sanitizes launch process type names, based on project assembly names, by filtering out invalid characters. ([#237](#237)) - Launch process commands with paths containing special characters (including spaces) are now properly quoted. ([#239](#239)) - The `test` launch process, added when targeting the test execution environment, now properly handles solution/project filenames containing special characters (including spaces). ([#240](#240))
Merged
heroku-linguist bot
added a commit
that referenced
this pull request
Mar 20, 2025
## heroku/dotnet ### Changed - The buildpack now sanitizes launch process type names, based on project assembly names, by filtering out invalid characters. ([#237](#237)) - Launch process commands with paths containing special characters (including spaces) are now properly quoted. ([#239](#239)) - The `test` launch process, added when targeting the test execution environment, now properly handles solution/project filenames containing special characters (including spaces). ([#240](#240)) Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
heroku-linguist bot
added a commit
to heroku/cnb-builder-images
that referenced
this pull request
Mar 20, 2025
## heroku/dotnet ### Changed - The buildpack now sanitizes launch process type names, based on project assembly names, by filtering out invalid characters. ([#237](heroku/buildpacks-dotnet#237)) - Launch process commands with paths containing special characters (including spaces) are now properly quoted. ([#239](heroku/buildpacks-dotnet#239)) - The `test` launch process, added when targeting the test execution environment, now properly handles solution/project filenames containing special characters (including spaces). ([#240](heroku/buildpacks-dotnet#240))
heroku-linguist bot
added a commit
to heroku/cnb-builder-images
that referenced
this pull request
Mar 20, 2025
## heroku/dotnet ### Changed - The buildpack now sanitizes launch process type names, based on project assembly names, by filtering out invalid characters. ([#237](heroku/buildpacks-dotnet#237)) - Launch process commands with paths containing special characters (including spaces) are now properly quoted. ([#239](heroku/buildpacks-dotnet#239)) - The `test` launch process, added when targeting the test execution environment, now properly handles solution/project filenames containing special characters (including spaces). ([#240](heroku/buildpacks-dotnet#240)) Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors how the
testexecution environment launch process is defined:dotnetCLI is now invoked directly (without bash wrapping).dotnetcommand, avoiding the need to escape/quote arguments containing special characters or spaces and enabling support for, for instance, solution/project names containing special characters.Also see this related PR implementing support for the changes introduced in the classic .NET buildpack