Filter allowed process type characters #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runesoerensen
changed the title
runesoerensen
force-pushed
the
sanitize-launch-process-type
branch
from
327c0cd to
e565d36
Compare
runesoerensen
force-pushed
the
refactor-launch-process-detection
branch
from
d5f67b2 to
8ba461d
Compare
runesoerensen
force-pushed
the
sanitize-launch-process-type
branch
from
e565d36 to
cb4eb55
Compare
runesoerensen
force-pushed
the
sanitize-launch-process-type
branch
from
cb4eb55 to
04c1da9
Compare
edmorley
approved these changes
Mar 19, 2025
There was a problem hiding this comment.
Future improvements to consider:
Longer term we'll also likely need to update a few things (here and in other components) due to the upcoming RFC1123 subdomain format validation change:
https://github.com/heroku/lyra-runtime/pulls?q=is%3Apr+RFC1123
https://salesforce-internal.slack.com/archives/CCKDG0FAT/p1741792195879209
https://salesforce-internal.slack.com/archives/CAJNZ67FF/p1733907948659819
heroku-linguist bot
added a commit
that referenced
this pull request
Mar 20, 2025
## heroku/dotnet ### Changed - The buildpack now sanitizes launch process type names, based on project assembly names, by filtering out invalid characters. ([#237](#237)) - Launch process commands with paths containing special characters (including spaces) are now properly quoted. ([#239](#239)) - The `test` launch process, added when targeting the test execution environment, now properly handles solution/project filenames containing special characters (including spaces). ([#240](#240))
Merged
heroku-linguist bot
added a commit
that referenced
this pull request
Mar 20, 2025
## heroku/dotnet ### Changed - The buildpack now sanitizes launch process type names, based on project assembly names, by filtering out invalid characters. ([#237](#237)) - Launch process commands with paths containing special characters (including spaces) are now properly quoted. ([#239](#239)) - The `test` launch process, added when targeting the test execution environment, now properly handles solution/project filenames containing special characters (including spaces). ([#240](#240)) Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
heroku-linguist bot
added a commit
to heroku/cnb-builder-images
that referenced
this pull request
Mar 20, 2025
## heroku/dotnet ### Changed - The buildpack now sanitizes launch process type names, based on project assembly names, by filtering out invalid characters. ([#237](heroku/buildpacks-dotnet#237)) - Launch process commands with paths containing special characters (including spaces) are now properly quoted. ([#239](heroku/buildpacks-dotnet#239)) - The `test` launch process, added when targeting the test execution environment, now properly handles solution/project filenames containing special characters (including spaces). ([#240](heroku/buildpacks-dotnet#240))
heroku-linguist bot
added a commit
to heroku/cnb-builder-images
that referenced
this pull request
Mar 20, 2025
## heroku/dotnet ### Changed - The buildpack now sanitizes launch process type names, based on project assembly names, by filtering out invalid characters. ([#237](heroku/buildpacks-dotnet#237)) - Launch process commands with paths containing special characters (including spaces) are now properly quoted. ([#239](heroku/buildpacks-dotnet#239)) - The `test` launch process, added when targeting the test execution environment, now properly handles solution/project filenames containing special characters (including spaces). ([#240](heroku/buildpacks-dotnet#240)) Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently use the project assembly name to build launch process types. However, assembly names can include several characters that are not allowed in the CNB spec.
This PR changes the launch process type to only include characters allowed by the CNB spec, eliminating the need to warn users when an invalid character is included in the assembly name. It also allows us to safely make the
detect_solution_processinfallible, reducing code complexity in the process.Future improvements to consider:
foo+bar.csproj,foobar.csproj,foo bar.csprojwill all use thefoobarprocess type name), which the CNB spec doesn't allow..and upper-case characters #188, we may want to also filter out., even if it's allowed under the CNB spec, to increase compatibility with theProcfilespec (which only allows alphanumeric characters + hyphens and underscores). Using.in .NET project names (e.g.MyApp.Frontend) is fairly common, so this is more likely to cause issues for users of this buildpack.