Prefer solution file name in test process command #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the test launch process command to use the solution file name rather than the absolute path. The motivation for this change is the same as #138. In this case, however, there's no need to also change directory, as we're only testing the solution file, which is required to be in the working directory.
edmorley
approved these changes
Mar 18, 2025
runesoerensen
added a commit
to heroku/heroku-buildpack-dotnet
that referenced
this pull request
Mar 19, 2025
The `dotnet test` command was changed to use only the solution file name in heroku/buildpacks-dotnet#233
heroku-linguist bot
added a commit
to heroku/heroku-buildpack-dotnet
that referenced
this pull request
Mar 19, 2025
* Update DOTNET_CNB_VERSION version to 0.3.5 * Update test to reflect change in test command The `dotnet test` command was changed to use only the solution file name in heroku/buildpacks-dotnet#233 * Add PR link to changelog entry * Remove whitespace --------- Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com> Co-authored-by: Rune Soerensen <rsoerensen@salesforce.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the test launch process command, registered when targeting the
testexecution environment, to use only the solution file name rather than the absolute solution file path.The motivation for this change is the same as #138 (though there's no need to change directory in this case, as we're only testing the solution file, which is currently always found in the workspace/build directory root). More specifically, it'll allow running the
testprocess type in (currently unsupported) environments, such as local integration tests, or Heroku apps built withCNB_EXEC_ENV=testusingheroku run test.This shouldn't change the current behavior in any supported environments (including Heroku CI), which all execute the test command from the working directory containing the solution file.