Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm-framework: ModifyPlan refactor 2 #1514

Merged
merged 4 commits into from
Oct 25, 2024
Merged

helm-framework: ModifyPlan refactor 2 #1514

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
974fdeb
initial refactoring of plan.lint with lintModifyPlan
BBBmau Oct 24, 2024
833280a
replace tflog with diagnostics when cluster is unreachable
BBBmau Oct 24, 2024
c388c75
set state.Version as StringNull instead of plan.Version
BBBmau Oct 24, 2024
86f839c
Revert "initial refactoring of plan.lint with lintModifyPlan"
BBBmau Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions helm-framework/helm/resource_helm_release.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1791,7 +1791,7 @@ func (r *HelmRelease) ModifyPlan(ctx context.Context, req resource.ModifyPlanReq
if strings.Contains(err.Error(), "Kubernetes cluster unreachable") {
// FIXME add diagnostic here

tflog.Debug(ctx, "cluster was unreachable at create time, marking manifest as computed")
resp.Diagnostics.AddError("cluster was unreachable at create time, marking manifest as computed", err.Error())
plan.Manifest = types.StringNull()
return
}
Expand Down Expand Up @@ -1904,7 +1904,7 @@ func (r *HelmRelease) ModifyPlan(ctx context.Context, req resource.ModifyPlanReq
if len(chart.Metadata.Version) > 0 {
plan.Version = types.StringValue(chart.Metadata.Version)
} else {
plan.Version = types.StringNull()
state.Version = types.StringNull()
}
resp.Plan.Set(ctx, &plan)
}
Expand Down
Loading