Skip to content

Commit

Permalink
fix unknown value error by using ObjectUnknown instead of ObjectNull()
Browse files Browse the repository at this point in the history
  • Loading branch information
BBBmau committed Oct 25, 2024
1 parent c355f59 commit 3a5e45b
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions helm-framework/helm/resource_helm_release.go
Original file line number Diff line number Diff line change
Expand Up @@ -1458,7 +1458,7 @@ func setReleaseAttributes(ctx context.Context, state *HelmReleaseModel, r *relea
}

// Convert the list of ObjectValues to a ListValue
metadataList, diag := types.ObjectValue(metadataAttrTypes(), metadata)
metadataObject, diag := types.ObjectValue(metadataAttrTypes(), metadata)
diags.Append(diag...)
if diags.HasError() {
tflog.Error(ctx, "Error converting metadata to ListValue", map[string]interface{}{
Expand All @@ -1470,8 +1470,8 @@ func setReleaseAttributes(ctx context.Context, state *HelmReleaseModel, r *relea
}

// Log metadata after conversion
tflog.Debug(ctx, fmt.Sprintf("Metadata after conversion: %+v", metadataList))
state.Metadata = metadataList
tflog.Debug(ctx, fmt.Sprintf("Metadata after conversion: %+v", metadataObject))
state.Metadata = metadataObject
return diags
}

Expand Down Expand Up @@ -1657,7 +1657,7 @@ func (r *HelmRelease) ModifyPlan(ctx context.Context, req resource.ModifyPlanReq

if recomputeMetadata(plan, state) {
tflog.Debug(ctx, fmt.Sprintf("%s Metadata has changes, setting to unknown", logID))
plan.Metadata = types.ObjectNull(metadataAttrTypes())
plan.Metadata = types.ObjectUnknown(metadataAttrTypes())
}

if !useChartVersion(plan.Chart.ValueString(), plan.Repository.ValueString()) {
Expand All @@ -1670,7 +1670,7 @@ func (r *HelmRelease) ModifyPlan(ctx context.Context, req resource.ModifyPlanReq

if oldVersionStr != newVersionStr && newVersionStr != "" {
// Setting Metadata to a computed value
plan.Metadata = types.ObjectNull(metadataAttrTypes())
plan.Metadata = types.ObjectUnknown(metadataAttrTypes())
}
}
}
Expand Down

0 comments on commit 3a5e45b

Please sign in to comment.