Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Improved card visibility on dark mode #870

Merged
merged 3 commits into from
Sep 1, 2024
Merged

fix: Improved card visibility on dark mode #870

merged 3 commits into from
Sep 1, 2024

Conversation

TomRytt
Copy link
Collaborator

@TomRytt TomRytt commented Aug 30, 2024

Description

Fixes issue #847 - #847

Added a white border and a slightly brighter gradient to the Card component inside the widget component in dark mode.

screenshots

Page:
image

Code:
image

Style:
image

@NoamGaash

@TomRytt TomRytt requested a review from NoamGaash as a code owner August 30, 2024 09:38
@TomRytt TomRytt changed the title fix/improved card visibility on dark mode fix/: Improved card visibility on dark mode Aug 30, 2024
@TomRytt TomRytt changed the title fix/: Improved card visibility on dark mode fix: Improved card visibility on dark mode Aug 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 30, 2024 •
edited
Loading

Preview: https://s3.amazonaws.com/noam-gaash.co.il/10643878050/open-bus/76/index.html
Preview Storybook: https://s3.amazonaws.com/noam-gaash.co.il/10643878050/open-bus/76/storybook/index.html
Test Report (if available): 'https://s3.amazonaws.com/noam-gaash.co.il/10643878050/open-bus/af66f6cdbe4dfad6fa68ff6c2c3a6662292c9e31/test-results/index.html'

@NoamGaash
Copy link
Member

https://s3.amazonaws.com/noam-gaash.co.il/10630431273/open-bus/c06e8e28d922dc950669a62227deb7a12e5a436f/test-results/index.html

NoamGaash
NoamGaash approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks amazing, well done 👏

@TomRytt TomRytt merged commit 527f974 into main Sep 1, 2024
15 of 16 checks passed
@TomRytt TomRytt deleted the fix--card-visibility-on-dark-mode branch September 1, 2024 05:41
@github-actions github-actions bot mentioned this pull request Sep 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoamGaash NoamGaash NoamGaash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomRytt @NoamGaash