feat: redesigning home page #395
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoamGaash
reviewed
Jan 16, 2024
| <Title level={3}>{t('rides_history')}</Title> | ||
| <Space direction="vertical" size="middle" style={{ marginBottom: '22px' }}> | ||
| <Alert message={t('timestamp_list')} type="info" /> | ||
| </Space> | ||
|
|
||
| main |
| <Route path="release" element={<iframe src="https://noam-gaash.co.il/databus/" />} /> | ||
| <Route path="*" element={<RedirectToDashboard />} key="back" /> | ||
| <Route path="*" element={<RedirectToHome />} key="back" /> | ||
| main |
NoamGaash
reviewed
Jan 16, 2024
src/pages/homepage/HomePage.scss
Outdated
There was a problem hiding this comment.
why removed? i need it for the styles
NoamGaash
approved these changes
Jan 17, 2024
|
I'm closing this PR and opening a cleaner one. |
NoamGaash
reviewed
Jan 18, 2024
There was a problem hiding this comment.
if we're going to use that, please add an attribution section in bottom of the about page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be an ongoing PR for designing the new homepage.