Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tooltip text alignment in hebrew locale #1039

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: tooltip text alignment in hebrew locale #1039

wants to merge 1 commit into from

Conversation

Hatzilu
Copy link

@Hatzilu Hatzilu commented Feb 16, 2025

Description

Fixes #1038

screenshots

before after
image image

@Hatzilu Hatzilu requested a review from NoamGaash as a code owner February 16, 2025 08:31
@Hatzilu Hatzilu changed the title Fix: fix tooltip text alignment in hebrew locale fix: tooltip text alignment in hebrew locale Feb 16, 2025
@github-actions GitHub Actions
Copy link
Contributor

Preview: https://s3.amazonaws.com/noam-gaash.co.il/13353315307/open-bus/353/index.html
Preview Storybook: https://s3.amazonaws.com/noam-gaash.co.il/13353315307/open-bus/353/storybook/index.html
Test Report (if available): 'https://s3.amazonaws.com/noam-gaash.co.il/13353315307/open-bus/c564e7b013b89a54e4200ef9865a8105e9bd74bd/test-results/index.html'

NoamGaash
NoamGaash reviewed Feb 16, 2025
View reviewed changes
Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool! did you make sure that the English version still looks fine?

@Hatzilu
Copy link
Author

Hatzilu commented Feb 16, 2025

cool! did you make sure that the English version still looks fine?

Yes, The tooltip looks correct in the english version, I also took a glance at all the other pages and they looked fine, though I didn't check any specific feature.

NoamGaash
NoamGaash approved these changes Feb 16, 2025
View reviewed changes
Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks great to me.
Maybe I'll make an issue for the lack of visual tests for the English version of the app later.
Nice catch and great contribution, thank you

@NoamGaash
Copy link
Member

@all-contributors please add @Hatzilu as code contributor

@allcontributors allcontributors bot mentioned this pull request Feb 16, 2025
Open
@allcontributors AllContributors
Copy link
Contributor

@NoamGaash

I've put up a pull request to add @Hatzilu! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoamGaash NoamGaash NoamGaash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tooltip text is not aligned correctly in hebrew locale
2 participants
@Hatzilu @NoamGaash