Skip to content

Commit

Permalink
remove the need for the data container recipe
Browse files Browse the repository at this point in the history
Volumes can be added through docker-compose.yml
  • Loading branch information
greg0ire committed Oct 16, 2015
1 parent c128aa6 commit 7df44ef
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 12 deletions.
8 changes: 2 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,11 @@ in your app.

1. Create a docker directory, in order to have a clean separation from the rest
of the project.
2. Create a `Dockerfile`. It will contain the definition for
the data container of your application. It should consist only of `VOLUME`
statements, defining which files and directories will be shared with the containers.
Make sure to only use `VOLUMES` corresponding to containers you will be using.
3. Create any configuration file needed by the containers you intend to use.
2. Create any configuration file needed by the containers you intend to use.
Configuration files could be part of the image rather than mounted on it, that is
true, but having them as part of your application is great, because it makes explicit
what will be needed when deploying the application.
4. Create a `docker-compose.yml` file and map the volume with paths on your host.
3. Create a `docker-compose.yml` file and map the volume with paths on your host.

## The containers

Expand Down
4 changes: 3 additions & 1 deletion dockeronify/templates/default/src/docker-compose.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
# This container is specific to the application.
# It contains configuration and data for other containers.
data:
build: ./docker
image: ubuntu:trusty
volumes:
- .:/srv
- ./docker/conf/nginx_vhost.conf:/etc/nginx/sites-enabled/my_app.conf
- .home-developer:/home/developer
- $SSH_AUTH_SOCK:/tmp/agent.sock
- /var/lib/postgresql/data
- /var/lib/elasticsearch

webserver:
image: greg0ire/nginx
Expand Down
5 changes: 0 additions & 5 deletions sample_symfony_app/docker/Dockerfile

This file was deleted.

0 comments on commit 7df44ef

Please sign in to comment.